Add linting workflow and address identified issues #120
Merged
stevenhartley merged 3 commits intoeclipse-uprotocol:mainfrom Jun 13, 2024
Merged
Add linting workflow and address identified issues #120stevenhartley merged 3 commits intoeclipse-uprotocol:mainfrom
stevenhartley merged 3 commits intoeclipse-uprotocol:mainfrom
Conversation
|
Code coverage report is ready! 📈
|
stevenhartley
approved these changes
Jun 13, 2024
stevenhartley
left a comment
stevenhartley
left a comment
There was a problem hiding this comment.
LGTM, there are some formatting errors in the cloudevent code but I'm removing that code now. Also the UUIDv8 spec section formatting is messed up now but that will also be removed when I switch from v8 to v7 per the spec change for alpha.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed issues detected by Checkstyle and PMD, including:
Checkstyle : For enforcing coding standards and style guidelines.
PMD : For detecting unused variables, and other potential issues. It finds common programming flaws like unused variables, empty catch blocks, unnecessary object creation, and so forth.